guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch

danielos
Hi :)

Guacamole server 0.9.12-incubating does not compile after upgrading
debian jessie to debian stretch. It compiled before on jessie.

ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined
but not used [-Werror=unused-function]
  static void guac_common_ssh_openssl_locking_callback(int mode, int n,
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors



------------------------------------------------
guacamole-server version 0.9.12-incubating
------------------------------------------------

    Library status:

      freerdp ............. yes
      pango ............... yes
      libavcodec .......... yes
      libavutil ........... yes
      libssh2 ............. yes
      libssl .............. yes
      libswscale .......... yes
      libtelnet ........... yes
      libVNCServer ........ yes
      libvorbis ........... yes
      libpulse ............ yes
      libwebp ............. yes

    Protocol support:

       RDP ....... yes
       SSH ....... yes
       Telnet .... yes
       VNC ....... yes

    Services / tools:

       guacd ...... yes
       guacenc .... yes

    Init scripts: no

Type "make" to compile guacamole-server.

lucky:~/download/guacamole-server-0.9.12-incubating# make
make  all-recursive
make[1]: Wejście do katalogu
'/root/download/guacamole-server-0.9.12-incubating'
Making all in src/libguac
make[2]: Wejście do katalogu
'/root/download/guacamole-server-0.9.12-incubating/src/libguac'
make[2]: Nie ma nic do zrobienia w 'all'.
make[2]: Opuszczenie katalogu
'/root/download/guacamole-server-0.9.12-incubating/src/libguac'
Making all in src/common
make[2]: Wejście do katalogu
'/root/download/guacamole-server-0.9.12-incubating/src/common'
make[2]: Nie ma nic do zrobienia w 'all'.
make[2]: Opuszczenie katalogu
'/root/download/guacamole-server-0.9.12-incubating/src/common'
Making all in src/libguacd
make[2]: Wejście do katalogu
'/root/download/guacamole-server-0.9.12-incubating/src/libguacd'
make[2]: Nie ma nic do zrobienia w 'all'.
make[2]: Opuszczenie katalogu
'/root/download/guacamole-server-0.9.12-incubating/src/libguacd'
Making all in tests
make[2]: Wejście do katalogu
'/root/download/guacamole-server-0.9.12-incubating/tests'
make[2]: Nie ma nic do zrobienia w 'all'.
make[2]: Opuszczenie katalogu
'/root/download/guacamole-server-0.9.12-incubating/tests'
Making all in src/common-ssh
make[2]: Wejście do katalogu
'/root/download/guacamole-server-0.9.12-incubating/src/common-ssh'
   CC       libguac_common_ssh_la-ssh.lo
ssh.c:89:22: error: ‘guac_common_ssh_openssl_id_callback’ defined but
not used [-Werror=unused-function]
  static unsigned long guac_common_ssh_openssl_id_callback() {
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined
but not used [-Werror=unused-function]
  static void guac_common_ssh_openssl_locking_callback(int mode, int n,
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:488: polecenia dla obiektu 'libguac_common_ssh_la-ssh.lo' nie
powiodły się
make[2]: *** [libguac_common_ssh_la-ssh.lo] Błąd 1
make[2]: Opuszczenie katalogu
'/root/download/guacamole-server-0.9.12-incubating/src/common-ssh'
Makefile:494: polecenia dla obiektu 'all-recursive' nie powiodły się
make[1]: *** [all-recursive] Błąd 1
make[1]: Opuszczenie katalogu
'/root/download/guacamole-server-0.9.12-incubating'
Makefile:426: polecenia dla obiektu 'all' nie powiodły się
make: *** [all] Błąd 2

Regards
Daniel Nguyen

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch

Valentin BRICE
Hi Daniel,

If I may, you issue here a common compilation error. It seems that the flag -Werror as been set in the Makefile. You may suppress the error removing the flag in the Makefile.

Regards.

Valentin

> On 31 Jul 2017, at 22:20, Daniel Nguyen <[hidden email]> wrote:
>
> Hi :)
>
> Guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch. It compiled before on jessie.
>
> ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined but not used [-Werror=unused-function]
> static void guac_common_ssh_openssl_locking_callback(int mode, int n,
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
>
>
> ------------------------------------------------
> guacamole-server version 0.9.12-incubating
> ------------------------------------------------
>
>   Library status:
>
>     freerdp ............. yes
>     pango ............... yes
>     libavcodec .......... yes
>     libavutil ........... yes
>     libssh2 ............. yes
>     libssl .............. yes
>     libswscale .......... yes
>     libtelnet ........... yes
>     libVNCServer ........ yes
>     libvorbis ........... yes
>     libpulse ............ yes
>     libwebp ............. yes
>
>   Protocol support:
>
>      RDP ....... yes
>      SSH ....... yes
>      Telnet .... yes
>      VNC ....... yes
>
>   Services / tools:
>
>      guacd ...... yes
>      guacenc .... yes
>
>   Init scripts: no
>
> Type "make" to compile guacamole-server.
>
> lucky:~/download/guacamole-server-0.9.12-incubating# make
> make  all-recursive
> make[1]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating'
> Making all in src/libguac
> make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/src/libguac'
> make[2]: Nie ma nic do zrobienia w 'all'.
> make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/src/libguac'
> Making all in src/common
> make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/src/common'
> make[2]: Nie ma nic do zrobienia w 'all'.
> make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/src/common'
> Making all in src/libguacd
> make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/src/libguacd'
> make[2]: Nie ma nic do zrobienia w 'all'.
> make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/src/libguacd'
> Making all in tests
> make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/tests'
> make[2]: Nie ma nic do zrobienia w 'all'.
> make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/tests'
> Making all in src/common-ssh
> make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/src/common-ssh'
>  CC       libguac_common_ssh_la-ssh.lo
> ssh.c:89:22: error: ‘guac_common_ssh_openssl_id_callback’ defined but not used [-Werror=unused-function]
> static unsigned long guac_common_ssh_openssl_id_callback() {
>                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined but not used [-Werror=unused-function]
> static void guac_common_ssh_openssl_locking_callback(int mode, int n,
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> Makefile:488: polecenia dla obiektu 'libguac_common_ssh_la-ssh.lo' nie powiodły się
> make[2]: *** [libguac_common_ssh_la-ssh.lo] Błąd 1
> make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/src/common-ssh'
> Makefile:494: polecenia dla obiektu 'all-recursive' nie powiodły się
> make[1]: *** [all-recursive] Błąd 1
> make[1]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating'
> Makefile:426: polecenia dla obiektu 'all' nie powiodły się
> make: *** [all] Błąd 2
>
> Regards
> Daniel Nguyen
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch

Mike Jumper
On Mon, Jul 31, 2017 at 1:34 PM, Valentin BRICE <[hidden email]> wrote:
Hi Daniel,

If I may, you issue here a common compilation error. It seems that the flag -Werror as been set in the Makefile. You may suppress the error removing the flag in the Makefile.


As a matter of practice, I strongly advise against ignoring the warnings. In this case, those functions deal with threadsafety, so the fact that they're turning up unused with your version of OpenSSL doesn't necessarily mean it's safe to leave them out, even if the compiler wouldn't normally consider that an error.

This particular issue should be fixed on master and in 0.9.13-incubating:


I suggest instead waiting for the 0.9.13-incubating release to be announced and published. It should be soon.

- Mike

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch

Valentin BRICE
Daniel,

You should follow Mike’s recommandations who is far more acknowledged about Guacamole than I am. You certainly should follow his advice against mine.

BR.

Valentin

On 31 Jul 2017, at 22:49, Mike Jumper <[hidden email]> wrote:

On Mon, Jul 31, 2017 at 1:34 PM, Valentin BRICE <[hidden email]> wrote:
Hi Daniel,

If I may, you issue here a common compilation error. It seems that the flag -Werror as been set in the Makefile. You may suppress the error removing the flag in the Makefile.


As a matter of practice, I strongly advise against ignoring the warnings. In this case, those functions deal with threadsafety, so the fact that they're turning up unused with your version of OpenSSL doesn't necessarily mean it's safe to leave them out, even if the compiler wouldn't normally consider that an error.

This particular issue should be fixed on master and in 0.9.13-incubating:


I suggest instead waiting for the 0.9.13-incubating release to be announced and published. It should be soon.

- Mike


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch

danielos
In reply to this post by danielos
I found what's going on.

libssl1.0-dev must be used instead of libssl-dev. Guacamole seems incompatible with libssl-dev in debian stretch, although ./configure does not complain.

Regards
Daniel Nguyen

W dniu 31.07.2017 o 22:20, Daniel Nguyen pisze:
Hi :)

Guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch. It compiled before on jessie.

ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined but not used [-Werror=unused-function]
 static void guac_common_ssh_openssl_locking_callback(int mode, int n,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors



------------------------------------------------
guacamole-server version 0.9.12-incubating
------------------------------------------------

   Library status:

     freerdp ............. yes
     pango ............... yes
     libavcodec .......... yes
     libavutil ........... yes
     libssh2 ............. yes
     libssl .............. yes
     libswscale .......... yes
     libtelnet ........... yes
     libVNCServer ........ yes
     libvorbis ........... yes
     libpulse ............ yes
     libwebp ............. yes

   Protocol support:

      RDP ....... yes
      SSH ....... yes
      Telnet .... yes
      VNC ....... yes

   Services / tools:

      guacd ...... yes
      guacenc .... yes

   Init scripts: no

Type "make" to compile guacamole-server.

lucky:~/download/guacamole-server-0.9.12-incubating# make
make  all-recursive
make[1]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating'
Making all in src/libguac
make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/src/libguac'
make[2]: Nie ma nic do zrobienia w 'all'.
make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/src/libguac'
Making all in src/common
make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/src/common'
make[2]: Nie ma nic do zrobienia w 'all'.
make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/src/common'
Making all in src/libguacd
make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/src/libguacd'
make[2]: Nie ma nic do zrobienia w 'all'.
make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/src/libguacd'
Making all in tests
make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/tests'
make[2]: Nie ma nic do zrobienia w 'all'.
make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/tests'
Making all in src/common-ssh
make[2]: Wejście do katalogu '/root/download/guacamole-server-0.9.12-incubating/src/common-ssh'
  CC       libguac_common_ssh_la-ssh.lo
ssh.c:89:22: error: ‘guac_common_ssh_openssl_id_callback’ defined but not used [-Werror=unused-function]
 static unsigned long guac_common_ssh_openssl_id_callback() {
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined but not used [-Werror=unused-function]
 static void guac_common_ssh_openssl_locking_callback(int mode, int n,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:488: polecenia dla obiektu 'libguac_common_ssh_la-ssh.lo' nie powiodły się
make[2]: *** [libguac_common_ssh_la-ssh.lo] Błąd 1
make[2]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating/src/common-ssh'
Makefile:494: polecenia dla obiektu 'all-recursive' nie powiodły się
make[1]: *** [all-recursive] Błąd 1
make[1]: Opuszczenie katalogu '/root/download/guacamole-server-0.9.12-incubating'
Makefile:426: polecenia dla obiektu 'all' nie powiodły się
make: *** [all] Błąd 2

Regards
Daniel Nguyen

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch

Mike Jumper
It is compatible - that's what the previously-posted JIRA issue dealt with:

https://issues.apache.org/jira/browse/GUACAMOLE-205

If you try building the 0.9.13-incubating release, which has the above
changes, you will not see these errors.

- Mike


On Sun, Aug 6, 2017 at 10:37 AM, Daniel Nguyen <[hidden email]> wrote:

> I found what's going on.
>
> libssl1.0-dev must be used instead of libssl-dev. Guacamole seems
> incompatible with libssl-dev in debian stretch, although ./configure does
> not complain.
>
> Regards
> Daniel Nguyen
>
> W dniu 31.07.2017 o 22:20, Daniel Nguyen pisze:
>
> Hi :)
>
> Guacamole server 0.9.12-incubating does not compile after upgrading debian
> jessie to debian stretch. It compiled before on jessie.
>
> ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined but
> not used [-Werror=unused-function]
>  static void guac_common_ssh_openssl_locking_callback(int mode, int n,
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
>
>
> ------------------------------------------------
> guacamole-server version 0.9.12-incubating
> ------------------------------------------------
>
>    Library status:
>
>      freerdp ............. yes
>      pango ............... yes
>      libavcodec .......... yes
>      libavutil ........... yes
>      libssh2 ............. yes
>      libssl .............. yes
>      libswscale .......... yes
>      libtelnet ........... yes
>      libVNCServer ........ yes
>      libvorbis ........... yes
>      libpulse ............ yes
>      libwebp ............. yes
>
>    Protocol support:
>
>       RDP ....... yes
>       SSH ....... yes
>       Telnet .... yes
>       VNC ....... yes
>
>    Services / tools:
>
>       guacd ...... yes
>       guacenc .... yes
>
>    Init scripts: no
>
> Type "make" to compile guacamole-server.
>
> lucky:~/download/guacamole-server-0.9.12-incubating# make
> make  all-recursive
> make[1]: Wejście do katalogu
> '/root/download/guacamole-server-0.9.12-incubating'
> Making all in src/libguac
> make[2]: Wejście do katalogu
> '/root/download/guacamole-server-0.9.12-incubating/src/libguac'
> make[2]: Nie ma nic do zrobienia w 'all'.
> make[2]: Opuszczenie katalogu
> '/root/download/guacamole-server-0.9.12-incubating/src/libguac'
> Making all in src/common
> make[2]: Wejście do katalogu
> '/root/download/guacamole-server-0.9.12-incubating/src/common'
> make[2]: Nie ma nic do zrobienia w 'all'.
> make[2]: Opuszczenie katalogu
> '/root/download/guacamole-server-0.9.12-incubating/src/common'
> Making all in src/libguacd
> make[2]: Wejście do katalogu
> '/root/download/guacamole-server-0.9.12-incubating/src/libguacd'
> make[2]: Nie ma nic do zrobienia w 'all'.
> make[2]: Opuszczenie katalogu
> '/root/download/guacamole-server-0.9.12-incubating/src/libguacd'
> Making all in tests
> make[2]: Wejście do katalogu
> '/root/download/guacamole-server-0.9.12-incubating/tests'
> make[2]: Nie ma nic do zrobienia w 'all'.
> make[2]: Opuszczenie katalogu
> '/root/download/guacamole-server-0.9.12-incubating/tests'
> Making all in src/common-ssh
> make[2]: Wejście do katalogu
> '/root/download/guacamole-server-0.9.12-incubating/src/common-ssh'
>   CC       libguac_common_ssh_la-ssh.lo
> ssh.c:89:22: error: ‘guac_common_ssh_openssl_id_callback’ defined but not
> used [-Werror=unused-function]
>  static unsigned long guac_common_ssh_openssl_id_callback() {
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined but
> not used [-Werror=unused-function]
>  static void guac_common_ssh_openssl_locking_callback(int mode, int n,
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> Makefile:488: polecenia dla obiektu 'libguac_common_ssh_la-ssh.lo' nie
> powiodły się
> make[2]: *** [libguac_common_ssh_la-ssh.lo] Błąd 1
> make[2]: Opuszczenie katalogu
> '/root/download/guacamole-server-0.9.12-incubating/src/common-ssh'
> Makefile:494: polecenia dla obiektu 'all-recursive' nie powiodły się
> make[1]: *** [all-recursive] Błąd 1
> make[1]: Opuszczenie katalogu
> '/root/download/guacamole-server-0.9.12-incubating'
> Makefile:426: polecenia dla obiektu 'all' nie powiodły się
> make: *** [all] Błąd 2
>
> Regards
> Daniel Nguyen
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: guacamole server 0.9.12-incubating does not compile after upgrading debian jessie to debian stretch

danielos
Thanks Mike, I'll do.

-Daniel
Loading...